Neutrino upgrade #68
Open
Neutrino upgrade #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianBorst
force-pushed
the
c/sdk-46-upgrade
branch
4 times, most recently
from
561c7f4 to
f9e73d7
Compare
ChristianBorst
force-pushed
the
c/sdk-46-upgrade
branch
8 times, most recently
from
2804ff9 to
3c90f71
Compare
This patch modifies the integration tests to run natively, as in without a container wrapping them, in github actions CI.
ChristianBorst
force-pushed
the
c/sdk-46-upgrade
branch
from
a2d0291 to
a2220e7
Compare
jkilpatr
reviewed
Dec 17, 2024
| // - ed25519 (Validators) | ||
| // | ||
| // - multisig (Cosmos SDK multisigs) | ||
| func CantoSigVerificationGasConsumer( |
There was a problem hiding this comment.
do we need this operation to consume gas? I mean the base tx fee is probably sufficient and I worry about correctness.
| @@ -153,19 +153,6 @@ func (suite *AnteTestSuite) TestEthSetPubkeyHandler() { | |||
| suite.Require().Error(err) | |||
| } | |||
| suite.Require().True(tc.correctPubKey(pubKey), "PubKey type incorrect after AnteHandler") | |||
|
|
|||
| // Now check the old antehandler against the same Tx, see if it would create a pubkey | |||
| ctx, _ = suite.ctx.CacheContext() | |||
| @@ -669,6 +710,8 @@ func NewAltheaApp( | |||
| ) | |||
| app.CrisisKeeper = &crisisKeeper | |||
|
|
|||
| // TODO: add feegrant keeper | |||
| // SDK /node_info, /syncing, /blocks, and /validatorsets REST endpoints | ||
| rpc.RegisterRoutes(clientCtx, apiSvr.Router) | ||
|
|
||
| // Note: Delegates requests to the EVM if given a hash variable with a leading "0x" |
There was a problem hiding this comment.
I know we use the evm rpc in the tests, maybe we should add a quick request to the standard rpc just to make sure it's working. Not sure if this code was supposed to go somewhere else or just isn't needed anymore.
| The *Neutrino* upgrade contains the following changes. | ||
|
|
||
| ## Summary of Changes | ||
|
|
| "encoding/json" | ||
|
|
||
| evmtypes "github.com/evmos/ethermint/x/evm/types" | ||
| ) |
There was a problem hiding this comment.
do we need this file at all?
| # Find the PID of the validator1 node | ||
| VALIDATOR_1_PID=$(ps -eafww | grep /validator1 | head -n1 | awk '{print $2}') | ||
|
|
||
| # Run dlv and attach to validator1 |
ChristianBorst
force-pushed
the
c/sdk-46-upgrade
branch
from
b7e7f3d to
1e6bcf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features: